fix(ui): remove unnecessary hard reload after delete #12930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove the hard `window.location.reload()` on deletion b/c the WorkflowsList page _does_ handle deletions
- not sure what didn't work about it before, the code has improved but is largely semantically equivalent
- I suspect it might have been the same root cause as the bug fixed by 9e7dc25
Signed-off-by: Anton Gilgur <[email protected]>
tczhao
approved these changes
Apr 22, 2024
isubasinghe
approved these changes
Apr 22, 2024
agilgur5
added a commit
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Anton Gilgur <[email protected]> (cherry picked from commit b1c3768)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11121 (comment)
Motivation
window.location.reload()on deletion b/c the WorkflowsList page does handle deletionsModifications
window.location.reload()and comments about itnavigation.gotois already there and already works properlyVerification
Tested deletion locally without the
window.location.reload()and it worked fine.Screenshots:
Before deletion --
coinflip-794pgexists:After deletion -- clicked into
coinflip-794pgand clicked Delete --coinflip-794pgno longer exists:Notes to Reviewers
Might notice that my screenshots are nearly 2 months old 😅 I haven't gotten back to UI work in a bit and this was leftover code that I had in my
git stash