Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error running 1000s of tasks: "etcdserver: request is too large" #1186 #1264

Merged
merged 16 commits into from
Mar 18, 2019
Merged

Error running 1000s of tasks: "etcdserver: request is too large" #1186 #1264

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
cb0ab97
Error running 1000s of tasks: "etcdserver: request is too large" #1186
sarabala1979 Mar 14, 2019
b365648
added Operator.go
sarabala1979 Mar 14, 2019
0af9f58
revert the testing yaml
sarabala1979 Mar 14, 2019
862307a
Fixed the lint issue
sarabala1979 Mar 15, 2019
be7603f
fixed
sarabala1979 Mar 15, 2019
9bedb33
fixed lint
sarabala1979 Mar 15, 2019
1195457
Fixed Testcase
sarabala1979 Mar 15, 2019
c7b3d1c
incorporated the review comments
sarabala1979 Mar 15, 2019
835373f
Reverted the change
sarabala1979 Mar 15, 2019
5f51681
incorporated review comments
sarabala1979 Mar 15, 2019
465a729
fixing gometalinter checks
sarabala1979 Mar 15, 2019
bac7d30
incorporated review comments
sarabala1979 Mar 17, 2019
64f8e0c
Update pod-limits.yaml
sarabala1979 Mar 18, 2019
ff7ddca
updated few comments
sarabala1979 Mar 18, 2019
ec3cc51
updated error message format
sarabala1979 Mar 18, 2019
fd8d8f7
reverted unwanted files
sarabala1979 Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed Testcase
  • Loading branch information
@sarabala1979
sarabala1979 committed Mar 15, 2019
commit 1195457006d2dd53205cb8fa2d92c18ad4608d95
3 changes: 2 additions & 1 deletion workflow/util/file/fileutil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,12 @@ func DecodeDecompressString(content string) (string, error) {
func CompressContent(content []byte) []byte {
var buf bytes.Buffer
zipWriter := gzip.NewWriter(&buf)
defer close(zipWriter)

_, err := zipWriter.Write(content)
if err != nil {
log.Warn("Error in compressing. v%", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be log.Warnf also it should be %v not v%.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

}
close(zipWriter)
return buf.Bytes()
}

Expand Down