Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): simplify Webpack config a bit #11594

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

agilgur5
Copy link
Contributor

Motivation

Simplify the Webpack config a tiny bit after having to work with it for #11593 and #11585

Modifications

  • makes it more similar to Argo CD's current config
    • using a proxyConf variable borrowed from there, though I thought that was a good simplification either way
    • console.log statement is very similar now, though slightly modified wording ("in" -> "for")
      • I was pretty confused by the isProd= log before, thought it had some significance, and thought it might have an error (due to the space), but it was actually just a log statement. So make it more clear this way
    • separate from: and to: to separate lines
      • better readability and usually formatters have rules for this style -- but there may be no formatter running on the config?

Verification

No semantic changes, just stylistic. Been using it for my local builds already, so builds definitely still pass. Just split this out as a separate, independent PR.

- makes it more similar to Argo CD's [current config](https://github.com/argoproj/argo-cd/blob/bfaac2b5ac4b96c8af8158902c1b086f7ced7389/ui/src/app/webpack.config.js#L10)
  - using a `proxyConf` variable borrowed from there, though I thought that was a good simplification either way
  - `console.log` statement is very similar now, though slightly modified wording ("in" -> "for")
    - I was pretty confused by the `isProd= ` log before, thought it had some significance, and thought it might have an error (due to the space), but it was actually just a log statement. So make it more clear this way

Signed-off-by: Anton Gilgur <[email protected]>
@terrytangyuan terrytangyuan merged commit e5d237a into argoproj:master Aug 17, 2023
22 checks passed
@agilgur5 agilgur5 deleted the refactor-webpack-config branch August 17, 2023 19:05
@agilgur5 agilgur5 added area/ui area/build Build or GithubAction/CI issues labels Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues area/ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants