docs: update PR template #11002
Merged
docs: update PR template #11002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Xu <[email protected]>
|
Open for review and let me know your concerns. Thanks! |
Joibel
reviewed
May 2, 2023
|
|
||
| ### Verification | ||
|
|
||
| <!-- TODO: Say how you tested your changes. --> |
There was a problem hiding this comment.
I's suggest that tests should be added or updated here too?
There was a problem hiding this comment.
Although, maybe not a hard requirement if the change is trivial?
Signed-off-by: Max Xu <[email protected]>
juliev0
approved these changes
May 8, 2023
terrytangyuan
approved these changes
May 8, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
Signed-off-by: Max Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Providing a more user-friendly contributing experience by making the PR template more structural and clear.
Modifications
Verification
Preview this PR itself.