Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update PR template #10641

Merged
merged 4 commits into from
Mar 5, 2023
Merged

docs: Update PR template #10641

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2142192
docs: Update PR template
alexec Mar 5, 2023
6cf0a97
docs: spelling
alexec Mar 5, 2023
6e6c1e2
Update pull_request_template.md
alexec Mar 5, 2023
f62d510
Update pull_request_template.md
alexec Mar 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update pull_request_template.md 
Signed-off-by: Alex Collins <[email protected]>
  • Loading branch information
@alexec
alexec authored Mar 5, 2023
commit 6e6c1e24ada30c0c5a4063d910ab64a8170039d7
6 changes: 3 additions & 3 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ Fixes #TODO
Do not open a PR until you have:

* Run `make pre-commit -B` to fix codegen and lint problems (build will fail).
* [Sign-off your commits](https://github.com/apps/dco/) (otherwise the DCO check will fail).
* Use [a conventional commit message](https://www.conventionalcommits.org/en/v1.0.0/).
* [Signed-off your commits](https://github.com/apps/dco/) (otherwise the DCO check will fail).
* Used [a conventional commit message](https://www.conventionalcommits.org/en/v1.0.0/).

alexec marked this conversation as resolved.
Show resolved Hide resolved

When you open your PR
Expand All @@ -22,4 +22,4 @@ When you open your PR

When changes are requested, please address them and then dismiss the review to get it reviewed again.

-->
-->