-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] The command exit code always be '0' in windows container #9797
Labels
Projects
Comments
Please submit PR to fix! |
PR submitted |
alexec
pushed a commit
that referenced
this issue
Oct 18, 2022
Signed-off-by: wsj_0000 <[email protected]>
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this issue
Nov 3, 2022
argoproj#9807) Signed-off-by: wsj_0000 <[email protected]> Signed-off-by: juchao <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The command exit code always be '0' in windows container. Because the wait function on windows only check the err but not with the exit code of the stat (The error might be redirect).
https://github.com/argoproj/argo-workflows/blob/aa59b43748f78e599709add871af7ec14e1fd3c1/workflow/executor/os-specific/signal_windows.go#L29
I tried to fix this by the code below:
This is just a temporary fix, so I just show my code here. Hope helpful.
The yaml below will reproduce the issue.
The text was updated successfully, but these errors were encountered: