Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to access artifacts from archived workflows breaks the UI #9772

Closed
2 of 3 tasks
nikita-akuity opened this issue Oct 8, 2022 · 4 comments · Fixed by #9836
Closed
2 of 3 tasks

Trying to access artifacts from archived workflows breaks the UI #9772

nikita-akuity opened this issue Oct 8, 2022 · 4 comments · Fixed by #9836
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc area/ui area/workflow-archive P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important type/bug

Comments

@nikita-akuity
Copy link

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issues exists when I tested with :latest
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

The artifact preview works perfectly with unarchived workflows, but when I'm trying to access same artifacts from the archived workflow I get this:

Screen.Recording.2022-10-07.at.7.23.01.PM.mov

Artifacts stored in AWS S3 with IRSA authentication.

Stacktrace:

react-dom.production.min.js:209 TypeError: Cannot read properties of undefined (reading 'type')
    at t.WorkflowNodeInfo (workflow-node-info.tsx:471:28)
    at Gi (react-dom.production.min.js:153:146)
    at gs (react-dom.production.min.js:261:496)
    at ul (react-dom.production.min.js:246:265)
    at sl (react-dom.production.min.js:246:194)
    at Xs (react-dom.production.min.js:239:172)
    at react-dom.production.min.js:123:115
    at t.unstable_runWithPriority (scheduler.production.min.js:19:467)
    at Vo (react-dom.production.min.js:122:325)
    at Ko (react-dom.production.min.js:123:61)

Network tab in the debug console:
Screen Shot 2022-10-07 at 8 12 10 PM

Headers from the failed request:

Request URL: https://<url>:2746/api/v1/workflow-events/single-wf-dev?listOptions.fieldSelector=metadata.namespace=single-wf-dev&listOptions.resourceVersion=1230367&fields=result.object.metadata.name,result.object.metadata.namespace,result.object.metadata.resourceVersion,result.object.metadata.creationTimestamp,result.object.metadata.uid,result.object.status.finishedAt,result.object.status.phase,result.object.status.message,result.object.status.startedAt,result.object.status.estimatedDuration,result.object.status.progress,result.type,result.object.metadata.labels,result.object.spec.suspend
Referrer Policy: strict-origin-when-cross-origin
#-----------------
Accept: text/event-stream
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.9
Cache-Control: no-cache
Connection: keep-alive
Cookie: authorization=Bearer k8s-aws-v1.<token>
Host: <url>:2746
Referer: https://<url>:2746/workflows/single-wf-dev?limit=50
sec-ch-ua: "Google Chrome";v="105", "Not)A;Brand";v="8", "Chromium";v="105"
sec-ch-ua-mobile: ?0
sec-ch-ua-platform: "macOS"
Sec-Fetch-Dest: empty
Sec-Fetch-Mode: cors
Sec-Fetch-Site: same-origin
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36

Version

3.4.1

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

---

Logs from the workflow controller

Logs from argo server, nothing is here:

grpc.service=workflowarchive.ArchivedWorkflowService grpc.start_time="2022-10-08T03:29:18Z" grpc.time_ms=8.271 span.kind=server system=grpc
time="2022-10-08T03:29:18.172Z" level=info duration=12.770649ms method=GET path=/api/v1/archived-workflows size=2920 status=0
time="2022-10-08T03:29:20.389Z" level=info msg="tracking UI usage️️" name=openedArchivedWorkflowDetails
time="2022-10-08T03:29:20.389Z" level=info msg="finished unary call with code OK" grpc.code=OK grpc.method=CollectEvent grpc.service=info.InfoService grpc.start_time="2022-10-08T03:29:20Z" grpc.time_ms=0.665 span.kind=server system=grpc
time="2022-10-08T03:29:20.390Z" level=info duration=1.336136ms method=POST path=/api/v1/tracking/event size=2 status=0
time="2022-10-08T03:29:20.666Z" level=info msg="finished unary call with code OK" grpc.code=OK grpc.method=GetArchivedWorkflow grpc.service=workflowarchive.ArchivedWorkflowService grpc.start_time="2022-10-08T03:29:20Z" grpc.time_ms=17.007 span.kind=server system=grpc
time="2022-10-08T03:29:20.670Z" level=info duration=20.67733ms method=GET path=/api/v1/archived-workflows/7582af45-29aa-4420-9e37-f4d2a79d265f size=21482 status=0
time="2022-10-08T03:29:21.352Z" level=info duration="119.691µs" method=GET path=index.html size=473 status=0

Logs from in your workflow's wait container


@tooptoop4
Copy link
Contributor

dupe of #9627 ?

@juliev0
Copy link
Contributor

juliev0 commented Oct 10, 2022

dupe of #9627 ?

Yes, it seems to be. I added a comment there.

@sarabala1979 sarabala1979 added type/feature Feature request P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important and removed type/feature Feature request labels Oct 11, 2022
@stale
Copy link

stale bot commented Oct 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Oct 29, 2022
@tooptoop4
Copy link
Contributor

crispy

@stale stale bot removed the problem/stale This has not had a response in some time label Oct 29, 2022
alexec added a commit that referenced this issue Oct 29, 2022
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this issue Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc area/ui area/workflow-archive P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants