Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.4rc2 - Archived Workflows are left-aligned #9433

Closed
3 tasks done
tim-sendible opened this issue Aug 25, 2022 · 5 comments · Fixed by #9439
Closed
3 tasks done

3.4rc2 - Archived Workflows are left-aligned #9433

tim-sendible opened this issue Aug 25, 2022 · 5 comments · Fixed by #9439
Labels
area/ui type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@tim-sendible
Copy link
Contributor

tim-sendible commented Aug 25, 2022 •
edited
Loading

Checklist

  • Double-checked my configuration.
  • Tested using the latest version.
  • Used the Emissary executor.

Summary

What happened/what you expected to happen?
Upgraded from 3.3.9 to 3.4rc2 and the archived workflows are now all left-aligned and hard to navigate as a result. I couldn't really give you a detailed screenshot, but I hope you get the idea:
image

What version are you running? 3.4rc2
Firefox 103 on macOS 12.5.1

Message from the maintainers:

Impacted by this regression? Give it a 👍. We prioritise the issues with the most 👍.
@tim-sendible tim-sendible added type/bug type/regression Regression from previous behavior (a specific type of bug) triage labels Aug 25, 2022
terrytangyuan added a commit to terrytangyuan/argo-workflows that referenced this issue Aug 25, 2022
@terrytangyuan
fix: Incorrect alignment for archived workflow. Fixes argoproj#9433
a0ae49a 
Signed-off-by: Yuan Tang <[email protected]>
@terrytangyuan terrytangyuan mentioned this issue Aug 25, 2022
Merged
@terrytangyuan
Copy link
Member

Should be fixed via #9439.

terrytangyuan added a commit that referenced this issue Aug 25, 2022
@terrytangyuan
fix: Incorrect alignment for archived workflow. Fixes #9433 (#9439)
a09172a 
Signed-off-by: Yuan Tang <[email protected]>

Signed-off-by: Yuan Tang <[email protected]>
@tim-sendible
Copy link
Contributor Author

This is NOT fixed in rc3.

@terrytangyuan
Copy link
Member

@sarabala1979 I noticed that rc3 is released. What is the process to include commits to cherry-pick to rc releases?

@alexec alexec added the area/ui label Sep 6, 2022
@tim-sendible
Copy link
Contributor Author

This remains an issue in rc4

@rajaie-sg
Copy link

This issue still exists in 3.4 #9614

@terrytangyuan terrytangyuan reopened this Sep 19, 2022
@dakotalillie dakotalillie mentioned this issue Sep 20, 2022
Merged
terrytangyuan pushed a commit that referenced this issue Sep 22, 2022
@dakotalillie
fix: broken archived workflows ui. Fixes #9614, #9433 (#9634)
e6eb02f 
fix: broken archived workflows ui

Signed-off-by: Dakota Lillie <[email protected]>

Signed-off-by: Dakota Lillie <[email protected]>
chenyangxueHDU pushed a commit to chenyangxueHDU/argo that referenced this issue Sep 29, 2022
@dakotalillie
fix: broken archived workflows ui. Fixes argoproj#9614, argoproj#9433 (…
3bae3bf 
…argoproj#9634)

fix: broken archived workflows ui

Signed-off-by: Dakota Lillie <[email protected]>

Signed-off-by: Dakota Lillie <[email protected]>
Signed-off-by: yangxue.chen <[email protected]>
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this issue Nov 3, 2022
@terrytangyuan @juchaosong
fix: Incorrect alignment for archived workflow. Fixes argoproj#9433 (a…
7c5a7df 
…rgoproj#9439)

Signed-off-by: Yuan Tang <[email protected]>

Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: juchao <[email protected]>
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this issue Nov 3, 2022
@dakotalillie @juchaosong
fix: broken archived workflows ui. Fixes argoproj#9614, argoproj#9433 (…
e9dc833 
…argoproj#9634)

fix: broken archived workflows ui

Signed-off-by: Dakota Lillie <[email protected]>

Signed-off-by: Dakota Lillie <[email protected]>
Signed-off-by: juchao <[email protected]>
@sarabala1979 sarabala1979 mentioned this issue Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ui type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Incorrect alignment for archived workflow. Fixes #9433 terrytangyuan/argo-workflows
4 participants
@alexec @terrytangyuan @tim-sendible @rajaie-sg