retryStrategy limit does not have a nil check

[dpadhiar]

retryStrategy.Limit is a pointer value which maybe be nil. This will because a panic when it is not checked before attempting to use IntVal.

argo-workflows/workflow/controller/operator.go

Lines 907 to 912 in 19eae92

	// See if we have waited past the deadline
	if time.Now().Before(waitingDeadline) && int32(len(node.Children)) <= retryStrategy.Limit.IntVal {
	woc.requeueAfter(timeToWait)
	retryMessage := fmt.Sprintf("Backoff for %s", humanize.Duration(timeToWait))
	return woc.markNodePhase(node.Name, node.Phase, retryMessage), false, nil
	}