Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreachable code in util/tls/tls.go #6950

Closed
chavacava opened this issue Oct 15, 2021 · 1 comment · Fixed by #6960
Closed

Unreachable code in util/tls/tls.go #6950

chavacava opened this issue Oct 15, 2021 · 1 comment · Fixed by #6960

Comments

@chavacava
Copy link
Contributor

argo-workflows/util/tls/tls.go

Lines 24 to 27 in 67fe87b

if err != nil {
log.Fatal(err)
os.Exit(2)
}

The os.Exit(2) function call is unreachable.

(Found by revive rule unreachable-code)
@alexec
Copy link
Contributor

alexec commented Oct 18, 2021

Would you like to fix?

@chavacava chavacava mentioned this issue Oct 18, 2021
Merged
alexec pushed a commit that referenced this issue Oct 18, 2021
@chavacava
fix: Unreachable code in util/tls/tls.go. Fixes #6950 (#6960)
cf9a6cd 
Signed-off-by: chavacava <[email protected]>
@sarabala1979 sarabala1979 mentioned this issue Oct 21, 2021
Closed
24 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this issue Oct 24, 2021
@chavacava @kriti-sc
fix: Unreachable code in util/tls/tls.go. Fixes argoproj#6950 (argopr…
afd9c13 
…oj#6960)

Signed-off-by: chavacava <[email protected]>
Signed-off-by: kriti-sc <[email protected]>
@alexec alexec mentioned this issue Nov 5, 2021
Closed
25 tasks
alexec pushed a commit that referenced this issue Nov 17, 2021
@chavacava @alexec
fix: Unreachable code in util/tls/tls.go. Fixes #6950 (#6960)
32ecc46 
Signed-off-by: chavacava <[email protected]>
@sarabala1979 sarabala1979 mentioned this issue Dec 15, 2021
Closed
73 tasks
@sarabala1979 sarabala1979 mentioned this issue Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Unreachable code in util/tls/tls.go. Fixes #6950
2 participants
@alexec @chavacava