Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates using templateRef are broken in >=v3.0 #6076

Closed
alexec opened this issue Jun 3, 2021 · 1 comment · Fixed by #6081
Closed

templates using templateRef are broken in >=v3.0 #6076

alexec opened this issue Jun 3, 2021 · 1 comment · Fixed by #6081
Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)
Milestone
v3.0

Comments

@alexec
Copy link
Contributor

alexec commented Jun 3, 2021 •
edited
Loading

These were removed in

f31e0c6 chore!: Remove deprecated fields (#5035)

This field has been deprecated for some time and was removed in v3.0. I'm not sure that this was clearly communicated, otherwise we'd have published a clear migration path for users, and would have followed this ourselves.

Deprecated fields removed in v3.0.

Field Notes
Template.Arguments ignored in v2.12
Template.Template used in v2.12 (as template ref)
Template.TemplateRef used in v2.12
TemplateRef.RuntimeResolution unused in v2.12
WorkflowSpec.TTLSecondsAfterFinished used in v2.12, for workflow TTL
@alexec alexec added type/bug type/regression Regression from previous behavior (a specific type of bug) labels Jun 3, 2021
@alexec alexec added this to the v3.0 milestone Jun 3, 2021
@alexec
Copy link
Contributor Author

alexec commented Jun 3, 2021

@sarabala1979 @whynowy @wanghong230

alexec added a commit to alexec/argo-workflows that referenced this issue Jun 3, 2021
@alexec
docs: Document upgrading. Fixes argoproj#6076
d3e7aec 
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec linked a pull request Jun 3, 2021 that will close this issue
docs: Document upgrading. Fixes #6076 #6081
Merged
alexec added a commit that referenced this issue Jun 3, 2021
@alexec
docs: Document upgrading. Fixes #6076 (#6081)
687da78
@sarabala1979 sarabala1979 mentioned this issue Jun 10, 2021
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

docs: Document upgrading. Fixes #6076 alexec/argo-workflows
1 participant
@alexec