Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestSignalsSuite/TestInjectedSidecar fails too often to be flakey IMHO #5627

Closed
Tracked by #7133
alexec opened this issue Apr 8, 2021 · 2 comments · Fixed by #5683
Closed
Tracked by #7133

TestSignalsSuite/TestInjectedSidecar fails too often to be flakey IMHO #5627

alexec opened this issue Apr 8, 2021 · 2 comments · Fixed by #5683
Assignees
@alexec
Labels
type/bug
Milestone
v3.0

Comments

@alexec
Copy link
Contributor

alexec commented Apr 8, 2021

Not quite sure if this is only Emissary or PNS:

=== RUN   TestSignalsSuite/TestInjectedSidecar
Submitting workflow  sidecar-injected-
Waiting 1m40s for workflow metadata.name=sidecar-injected-wxjgb
 ? sidecar-injected-wxjgb Workflow 0s      

 ● sidecar-injected-wxjgb   Workflow 0s      
 └ ◷ sidecar-injected-wxjgb Pod      0s      

 ● sidecar-injected-wxjgb   Workflow 0s      
 └ ◷ sidecar-injected-wxjgb Pod      0s      ContainerCreating

 ● sidecar-injected-wxjgb   Workflow 0s      
 └ ● sidecar-injected-wxjgb Pod      0s      

    signals_test.go:124: timeout after 1m40s waiting for condition
=== FAIL: SignalsSuite/TestInjectedSidecar
@alexec alexec added the type/bug label Apr 8, 2021
@alexec alexec self-assigned this Apr 9, 2021
@alexec
Copy link
Contributor Author

alexec commented Apr 14, 2021

PNS example:

https://github.com/argoproj/argo-workflows/runs/2344559289

@alexec
Copy link
Contributor Author

alexec commented Apr 15, 2021

Pretty sure this is only PNS.

alexec added a commit to alexec/argo-workflows that referenced this issue Apr 15, 2021
@alexec
fix(executor): More logs for PNS sidecar termination. argoproj#5627
df312cd 
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec linked a pull request Apr 15, 2021 that will close this issue
fix(executor): More logs for PNS sidecar termination. #5627 #5683
Merged
@alexec alexec added this to the v3.0 milestone Apr 15, 2021
alexec added a commit that referenced this issue Apr 16, 2021
@alexec
fix(executor): More logs for PNS sidecar termination. #5627 (#5683)
91c08cd
@simster7 simster7 mentioned this issue Apr 19, 2021
Closed
50 tasks
alexec added a commit that referenced this issue Apr 19, 2021
@alexec
fix(executor): More logs for PNS sidecar termination. #5627 (#5683)
9492e12 
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec mentioned this issue Nov 2, 2021
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/bug
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

fix(executor): More logs for PNS sidecar termination. #5627 alexec/argo-workflows
1 participant
@alexec