Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: JSON/YAML toggle does not work anymore #5613

Closed
alexec opened this issue Apr 7, 2021 · 1 comment · Fixed by #5620
Closed

ui: JSON/YAML toggle does not work anymore #5613

alexec opened this issue Apr 7, 2021 · 1 comment · Fixed by #5620
Assignees
@alexec
Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)
Milestone
v3.0

Comments

@alexec
Copy link
Contributor

alexec commented Apr 7, 2021

No description provided.

@alexec alexec added the type/bug label Apr 7, 2021
@alexec alexec added this to the v3.0 milestone Apr 7, 2021
@alexec alexec self-assigned this Apr 7, 2021
@alexec alexec added the type/regression Regression from previous behavior (a specific type of bug) label Apr 7, 2021
@alexec
Copy link
Contributor Author

alexec commented Apr 7, 2021

We need to add ObjectEditor:


    useEffect(() => editor.current.editor.setValue(stringify(parse(text), lang)), [lang]);

@alexec alexec mentioned this issue Apr 8, 2021
Merged
alexec added a commit that referenced this issue Apr 8, 2021
@alexec
fix(ui): Fix editor. Fixes #5613 Fixes #5617 (#5620)
b76fac7
This was referenced Apr 17, 2021
Closed
Closed
@simster7 simster7 mentioned this issue Apr 19, 2021
Closed
50 tasks
simster7 pushed a commit that referenced this issue Apr 19, 2021
@alexec @simster7
fix(ui): Fix editor. Fixes #5613 Fixes #5617 (#5620)
026c127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

fix(ui): Fix editor. Fixes #5613 Fixes #5617 alexec/argo-workflows
1 participant
@alexec