-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.12: EstimatorFactory
can result in >1Gi memory usage
#4801
Labels
Comments
alexec
added
type/bug
epic/scaling
type/regression
Regression from previous behavior (a specific type of bug)
labels
Dec 24, 2020
alexec
added a commit
to alexec/argo-workflows
that referenced
this issue
Dec 29, 2020
, argoproj#4806, argoproj#3551 Signed-off-by: Alex Collins <[email protected]>
1 task
1 task
alexec
added a commit
that referenced
this issue
Jan 4, 2021
simster7
pushed a commit
that referenced
this issue
Jan 4, 2021
saranyaeu2987
pushed a commit
to saranyaeu2987/argo-1
that referenced
this issue
Jan 5, 2021
, argoproj#4806 (argoproj#4808) Signed-off-by: Alex Collins <[email protected]> Signed-off-by: saranyaeu2987 <[email protected]>
Fix for this is out on https://github.com/argoproj/argo/releases/tag/v2.12.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Summary
util.FromUnstructured
does a lot of memory allocations, especially in loops. If we have access to anunstructured.Unstructured
and only need some of the information (any metadata, one or two fields) then we do not need to invoke it.Over time this type will start doing very large allocs resulting in rampant memory usage.
Fix: https://github.com/argoproj/argo/pull/4795/files#diff-c5ce6b47371bfd1984ffff5b3c51c4a92ac0af836a74b079d25bb79774cdc84aR49
The text was updated successfully, but these errors were encountered: