-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow whitespace in templates #4286
Labels
type/feature
Feature request
Comments
Good idea. Would you like to investigate how to fix this? |
I'm not that proficient in Go, but looks like in function replacement, ok := replaceMap[strings.TrimSpace(tag)] |
Want to submit a PR? |
👍 let me have a look |
idsvandermolen
added a commit
to idsvandermolen/argo
that referenced
this issue
Oct 17, 2020
There you go, PR #4310 |
btw I had to make a few |
alexcapras
pushed a commit
to alexcapras/argo
that referenced
this issue
Nov 12, 2020
…goproj#4286 (argoproj#4310) Signed-off-by: Alex Capras <[email protected]>
simster7
pushed a commit
that referenced
this issue
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Currently Argo does not allow white space in templating, rendering of
{{workflow.parameters.variable}}
does correctly work, however{{ workflow.parameters.variable }}
doesn't render the variable. Alsoargo lint
did not issue any warning or error.Use Cases
I often find it more readable when you can add whitespace to separate markers like
{{
and}}
from variable names.Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
The text was updated successfully, but these errors were encountered: