Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to automatically decompress zipped artifacts #3585

Closed
alexcapras opened this issue Jul 24, 2020 · 2 comments
Closed

Add ability to automatically decompress zipped artifacts #3585

alexcapras opened this issue Jul 24, 2020 · 2 comments
Labels
type/feature Feature request

Comments

@alexcapras
Copy link
Contributor

alexcapras commented Jul 24, 2020

Summary

Currently, the executer has the ability to automatically unpack tar-balled artifacts (.tar.gz). It might be nice to add the ability to do the same for zip files (.zip).

Motivation

Sometimes artifacts need to be zipped instead of tarred, but it's nice to still have the auto-unpack functionality.

Proposal

In executor.go, we check if an artifact is a tarball, using function isTarball and the artifact is untarred using untar. I propose we add similar functions for isZip and unzip to handle the zip usecase.

https://github.com/argoproj/argo/blob/cdc935ae76b3d7cc50a486695b40ff2f647b49bc/workflow/executor/executor.go#L184


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@alexcapras alexcapras added the type/feature Feature request label Jul 24, 2020
@alexec
Copy link
Contributor

alexec commented Sep 15, 2020

Would you like to submit a PR for this feature?

@alexcapras
Copy link
Contributor Author

@alexec alexec closed this as completed in 9c08433 Oct 3, 2020
alexcapras added a commit to alexcapras/argo that referenced this issue Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants