-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to automatically decompress zipped artifacts #3585
Labels
type/feature
Feature request
Comments
Would you like to submit a PR for this feature? |
just raised a PR: https://github.com/argoproj/argo/pull/4068/files |
alexcapras
added a commit
to alexcapras/argo
that referenced
this issue
Nov 12, 2020
(argoproj#4068) Signed-off-by: Alex Capras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Currently, the executer has the ability to automatically unpack tar-balled artifacts (.tar.gz). It might be nice to add the ability to do the same for zip files (.zip).
Motivation
Sometimes artifacts need to be zipped instead of tarred, but it's nice to still have the auto-unpack functionality.
Proposal
In executor.go, we check if an artifact is a tarball, using function
isTarball
and the artifact is untarred usinguntar
. I propose we add similar functions forisZip
andunzip
to handle the zip usecase.https://github.com/argoproj/argo/blob/cdc935ae76b3d7cc50a486695b40ff2f647b49bc/workflow/executor/executor.go#L184
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
The text was updated successfully, but these errors were encountered: