Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI editor should default to YAML #3543

Closed
foobarbecue opened this issue Jul 21, 2020 · 7 comments · Fixed by #3560
Closed

New UI editor should default to YAML #3543

foobarbecue opened this issue Jul 21, 2020 · 7 comments · Fixed by #3560
Assignees
Labels
good first issue Good for newcomers type/feature Feature request

Comments

@foobarbecue
Copy link
Contributor

Summary

It's nice that we can now edit in both JSON and YAML in the UI, but strange that it comes up JSON-first, since Argo and Kubernetes are generally thought of as YAML-based and the user expects to interact with YAML. YAML is also more succinct than JSON.

Proposal

All editors should display in YAML by default.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@foobarbecue foobarbecue added the type/feature Feature request label Jul 21, 2020
@crenshaw-dev
Copy link
Contributor

If I recall correctly, JSON is default because the YAML version does not support autocomplete. (feature demo: https://www.youtube.com/watch?v=IVDhZuo_cv4)

@foobarbecue
Copy link
Contributor Author

foobarbecue commented Jul 22, 2020

Ok... does somebody think that's a good reason? You kinda gotta pick a lane here. Can't have all the docs in YAML and the interface in JSON. And I doubt the whole project is going to switch because of an nice-to-have autocomplete feature.

@simster7
Copy link
Member

Perhaps we can simply store a user's preference in local storage? That way a user who prefers YAML won't have to switch every time

@simster7 simster7 self-assigned this Jul 22, 2020
@alexec
Copy link
Contributor

alexec commented Jul 22, 2020

I think it would be fine to start in YAML, as long as the text states something like "YAML supports basic completion, full auto-completion is available when switching to JSON"

@alexec
Copy link
Contributor

alexec commented Jul 22, 2020

This is a small UI only change anyone could do.

@simster7 simster7 removed their assignment Jul 22, 2020
@rbreeze rbreeze self-assigned this Jul 22, 2020
@rbreeze
Copy link
Member

rbreeze commented Jul 22, 2020

Addressed in #3560

@alexec
Copy link
Contributor

alexec commented Sep 2, 2020

Available for testing in v2.11.0-rc1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type/feature Feature request
Projects
None yet
5 participants