Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakey tests in operator_template_scope_test.go #2432

Closed
alexec opened this issue Mar 13, 2020 · 4 comments · Fixed by #2779
Closed

Fix flakey tests in operator_template_scope_test.go #2432

alexec opened this issue Mar 13, 2020 · 4 comments · Fixed by #2779
Assignees
@dtaniwaki
Labels
type/bug

Comments

@alexec
Copy link
Contributor

alexec commented Mar 13, 2020 •
edited
Loading

These are marked with SkipNow
alexec added a commit to alexec/argo-workflows that referenced this issue Mar 13, 2020
@alexec
test: Skip flakey tests in operator_template_scope_test.go. See argop…
e73ef40 
…roj#2432
@alexec alexec mentioned this issue Mar 13, 2020
Merged
5 tasks
@alexec
Copy link
Contributor Author

alexec commented Mar 13, 2020

@dtaniwaki do you want to own this?

alexec added a commit that referenced this issue Mar 13, 2020
@alexec
test: Skip flakey tests in operator_template_scope_test.go. See #2432 (…
7094433 
…#2433)
@dtaniwaki
Copy link
Member

I have fixed something about the informer. Does it solve the issue?
563b5b9

@alexec
Copy link
Contributor Author

alexec commented Mar 30, 2020

These tests are still skipped.

@dtaniwaki
Copy link
Member

It seems a fakeclient may have a race condition with its informer.
kubernetes/kubernetes#87472

@dtaniwaki dtaniwaki mentioned this issue Apr 22, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtaniwaki dtaniwaki

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(test): fix template scope tests. Fixes #2432
2 participants
@alexec @dtaniwaki