Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offload GC deletes offloaded data it should not #2170

Closed
3 of 4 tasks
alexec opened this issue Feb 4, 2020 · 0 comments · Fixed by #2172
Closed
3 of 4 tasks

Offload GC deletes offloaded data it should not #2170

alexec opened this issue Feb 4, 2020 · 0 comments · Fixed by #2172
Assignees
@alexec
Labels
type/bug
Projects
Argo Workflows OSS Kanban Board
Milestone
v2.5

Comments

@alexec
Copy link
Contributor

alexec commented Feb 4, 2020 •
edited
Loading

Checklist:

  • I've included the version.
  • I've included reproduction steps.
  • I've included the workflow YAML.
  • I've included the logs.

What happened:

Offloaded nodes were deleted from the database, but the wf was still in Kubernetes.

time="2020-02-04T22:58:56Z" level=info msg="Deleting old UIDs that are not live" len_old_uids=2 len_wfs=0
time="2020-02-04T22:58:56Z" level=debug msg="Deleting offloaded nodes" uid=c9f481ed-2cd6-49aa-a539-54c382fc632f

What you expected to happen:

Not that.

How to reproduce it (as minimally and precisely as possible):

Create a workflow that is offloaded and wait 5m.
@alexec alexec added this to the v2.5 milestone Feb 4, 2020
@alexec alexec self-assigned this Feb 4, 2020
@alexec alexec changed the title Offload GC appears to delete offloaded data it should not Offload GC deletes offloaded data it should not Feb 4, 2020
@alexec alexec mentioned this issue Feb 4, 2020
Closed
@alexec alexec added this to In progress in Argo Workflows OSS Kanban Board Feb 5, 2020
alexec added a commit to alexec/argo-workflows that referenced this issue Feb 5, 2020
@alexec
fix(archive): Only delete offoaded data we do not need. Fixes argopro…
1ae2300 
…j#2170 and argoproj#2156
@alexec alexec mentioned this issue Feb 5, 2020
Merged
4 tasks
Argo Workflows OSS Kanban Board automation moved this from In progress to Done Feb 6, 2020
alexec added a commit that referenced this issue Feb 6, 2020
@alexec
fix(archive): Only delete offloaded data we do not need. Fixes #2170 …
b9c828a 
…and #2156 (#2172)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/bug
Projects
No open projects
Argo Workflows OSS Kanban Board
Done
Milestone
v2.5
Development

Successfully merging a pull request may close this issue.

fix(archive): Only delete offloaded data we do not need. Fixes #2170 and #2156 alexec/argo-workflows
1 participant
@alexec