Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up any deprecated code not needed after migration to use apiclient.Client #2117

Closed
2 tasks
alexec opened this issue Jan 31, 2020 · 0 comments · Fixed by #2303
Closed
2 tasks

Clean-up any deprecated code not needed after migration to use apiclient.Client #2117

alexec opened this issue Jan 31, 2020 · 0 comments · Fixed by #2303
Labels
type/feature Feature request

Comments

@alexec
Copy link
Contributor

alexec commented Jan 31, 2020

Summary

What change you think needs making.

Motivation

To reduce tech-debt and provide a Golang client for external users.

Depended on by #1951.

Proposal

Please speak to @alexec about how to do this. You'll probably need to write new e2e tests, and as a find bugs you need to fix. You should be able to find where you need to make changes based on //DEPRECATED.

  • client/conn.go
  • common.go

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@alexec alexec added type/feature Feature request argo-server labels Jan 31, 2020
@alexec alexec added this to the v2.6 milestone Jan 31, 2020
@alexec alexec added this to To do in Argo Workflows OSS Kanban Board via automation Jan 31, 2020
@alexec alexec removed this from the v2.6 milestone Feb 6, 2020
@alexec alexec added the backlog label Feb 6, 2020
@alexec alexec added the S label Feb 14, 2020
@alexec alexec added this to the Backlog milestone Feb 19, 2020
@alexec alexec removed the backlog label Feb 19, 2020
alexec added a commit to alexec/argo-workflows that referenced this issue Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant