-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argo server should support controller instance ids #2004
Labels
type/feature
Feature request
Comments
We should also update e2e tests to use instance ID: #2005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
The workflow controller has a feature in which it can be configured with an "instance ID", which means it only operates on workflows with a specific label. The purpose of this feature is to allow multiple controllers to run in the same cluster, but sharded with a specific purpose (testing vs. ML), using different artifact repositories, etc....
Since the Argo API server is so closely tied to the controller, even relying on the same config map, it is also required that the API server also be able to filter out workflows with an instance ID. Meaning it would only be displaying workflows with the server configured instance id.
Similarly, there probably needs to be a feature such that any create requests of workflows going through the Argo API server, may want to automatically fill in an instance ID with the one that the API server is configured with. Going further, it may also desired to enforce instance IDs at the Argo API server (i.e. do not allow workflows with alternative or empty instance ids from being created).
I also am unsure what impact this feature has on workflow archiving. We may need to have workflow controller instance ID as a column in the database.
The text was updated successfully, but these errors were encountered: