Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo server should support controller instance ids #2004

Closed
jessesuen opened this issue Jan 16, 2020 · 1 comment · Fixed by #2365
Closed

Argo server should support controller instance ids #2004

jessesuen opened this issue Jan 16, 2020 · 1 comment · Fixed by #2365
Assignees
Labels
type/feature Feature request

Comments

@jessesuen
Copy link
Member

jessesuen commented Jan 16, 2020

Summary

The workflow controller has a feature in which it can be configured with an "instance ID", which means it only operates on workflows with a specific label. The purpose of this feature is to allow multiple controllers to run in the same cluster, but sharded with a specific purpose (testing vs. ML), using different artifact repositories, etc....

Since the Argo API server is so closely tied to the controller, even relying on the same config map, it is also required that the API server also be able to filter out workflows with an instance ID. Meaning it would only be displaying workflows with the server configured instance id.

Similarly, there probably needs to be a feature such that any create requests of workflows going through the Argo API server, may want to automatically fill in an instance ID with the one that the API server is configured with. Going further, it may also desired to enforce instance IDs at the Argo API server (i.e. do not allow workflows with alternative or empty instance ids from being created).

I also am unsure what impact this feature has on workflow archiving. We may need to have workflow controller instance ID as a column in the database.

@jessesuen jessesuen added the type/feature Feature request label Jan 16, 2020
@sarabala1979 sarabala1979 modified the milestone: v2.5 Jan 27, 2020
@alexec alexec added the M label Feb 14, 2020
@alexec
Copy link
Contributor

alexec commented Feb 14, 2020

We should also update e2e tests to use instance ID: #2005

@sarabala1979 sarabala1979 self-assigned this Feb 14, 2020
@alexec alexec added this to the Backlog milestone Feb 19, 2020
@alexec alexec removed the backlog label Feb 19, 2020
@whynowy whynowy assigned whynowy and unassigned sarabala1979 Mar 2, 2020
whynowy added a commit that referenced this issue Mar 13, 2020
* feat: instanceID support for argo server

* changes on cronWorkflowServer

* refactory

* keep refac

* refac

* simplify

* argo_workflows table change

* test cases

* rename

* revert

* address comments

* rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants