Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark suspended nodes as suspended with a unique symbol in the CLI #1896

Closed
simster7 opened this issue Dec 30, 2019 · 2 comments · Fixed by #2240
Closed

Mark suspended nodes as suspended with a unique symbol in the CLI #1896

simster7 opened this issue Dec 30, 2019 · 2 comments · Fixed by #2240
Assignees
Labels
good first issue Good for newcomers type/feature Feature request

Comments

@simster7
Copy link
Member

Currently, suspended nodes are marked with the running symbol even when they are suspended. The CLI ux should be changed to reflect that they are in fact suspended.

From this:

Name:                test-dgrc2
Namespace:           argo
ServiceAccount:      default
Status:              Running (Suspended)
Created:             Mon Dec 30 08:20:03 -0800 (6 seconds ago)
Started:             Mon Dec 30 08:20:03 -0800 (6 seconds ago)
Duration:            6 seconds

STEP                          PODNAME  DURATION  MESSAGE
 ● test-dgrc2 (sensorAction)
 └-● suspend (fail)

To maybe this:

Name:                test-dgrc2
Namespace:           argo
ServiceAccount:      default
Status:              Running (Suspended)
Created:             Mon Dec 30 08:20:03 -0800 (6 seconds ago)
Started:             Mon Dec 30 08:20:03 -0800 (6 seconds ago)
Duration:            6 seconds

STEP                          PODNAME  DURATION  MESSAGE
 ● test-dgrc2 (sensorAction)
 └- || suspend (fail)
@simster7 simster7 added the type/feature Feature request label Dec 30, 2019
@simster7 simster7 self-assigned this Dec 30, 2019
@simster7 simster7 removed their assignment Jan 14, 2020
@changhc
Copy link
Contributor

changhc commented Feb 1, 2020

Hello @simster7 , may I take this issue?

I'd like to know why you chose the symbol || as well. Is it the pause symbol?

I think maybe we can use the empty set symbol or circle with lower half black . Suspended nodes are still in the running state, so I think we can keep using circles for consistency.

@simster7
Copy link
Member Author

simster7 commented Feb 3, 2020

Hi @changhc, feel free to take over this issue! I was in fact trying to make a "pause" symbol. I think the pause symbol would be better -- it universally understood. While the symbol could be seen as more consistent, its meaning is also not as ubiquitous as the pause symbol.

If for some reason the pause symbol doesn't work out, we can explore other options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type/feature Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants