-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow-level PodSpecPatch is not applied to agent pod #12387
Labels
area/controller
Controller issues, panics
area/spec
Changes to the workflow specification.
area/templates/http
P3
Low priority
type/bug
Comments
The agent pod need to apply workflow level PodSpecPatch like the workflow pod does. # workflow/controller/agent.go
if woc.execWf.Spec.HasPodSpecPatch() {
patchedPodSpec, err := util.ApplyPodSpecPatch(pod.Spec, woc.execWf.Spec.PodSpecPatch)
if err != nil {
return nil, errors.Wrap(err, "", "Error applying PodSpecPatch")
}
pod.Spec = *patchedPodSpec
} |
jswxstw
added a commit
to jswxstw/argo-workflows
that referenced
this issue
Jan 2, 2024
…2387 Signed-off-by: oninowang <[email protected]>
jswxstw
added a commit
to jswxstw/argo-workflows
that referenced
this issue
Jan 2, 2024
…2387 Signed-off-by: oninowang <[email protected]>
jswxstw
added a commit
to jswxstw/argo-workflows
that referenced
this issue
Jan 3, 2024
…2387 Signed-off-by: oninowang <[email protected]>
jswxstw
added a commit
to jswxstw/argo-workflows
that referenced
this issue
Jan 3, 2024
…2387 Signed-off-by: oninowang <[email protected]>
terrytangyuan
pushed a commit
that referenced
this issue
Jan 3, 2024
…2440) Signed-off-by: oninowang <[email protected]> Co-authored-by: jswxstw <[email protected]>
hittingray
pushed a commit
to atlassian-forks/argo-workflows
that referenced
this issue
Jan 4, 2024
…2387 (argoproj#12440) Signed-off-by: oninowang <[email protected]> Co-authored-by: jswxstw <[email protected]> Signed-off-by: Raymond Chow <[email protected]>
hittingray
pushed a commit
to atlassian-forks/argo-workflows
that referenced
this issue
Jan 4, 2024
…2387 (argoproj#12440) Signed-off-by: oninowang <[email protected]> Co-authored-by: jswxstw <[email protected]> Signed-off-by: Raymond Chow <[email protected]>
sarabala1979
pushed a commit
that referenced
this issue
Jan 9, 2024
…2440) Signed-off-by: oninowang <[email protected]> Co-authored-by: jswxstw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/controller
Controller issues, panics
area/spec
Changes to the workflow specification.
area/templates/http
P3
Low priority
type/bug
Pre-requisites
:latest
What happened/what did you expect to happen?
As shown in the following workflow demo, we set a workflow-level podSpecPatch to schedule the pod directly to the node named virtual-node.
However, HTTP Tempalte will create a agent pod and podSpecPatch was not applied to it.
Version
latest
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: