fix(ui): missing url href formatting in template link. Fixes #9764 (#…

…9790) Signed-off-by: Tianchu Zhao <[email protected]>
argoproj · Oct 13, 2022 · ebae212 · ebae212
1 parent d4817ef
commit ebae212
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ui/src/app/cron-workflows/components/cron-workflow-details/cron-workflow-details.tsx b/ui/src/app/cron-workflows/components/cron-workflow-details/cron-workflow-details.tsx
@@ -165,7 +165,7 @@ export const CronWorkflowDetails = ({match, location, history}: RouteComponentPr
  if (cronWorkflow?.spec?.workflowSpec?.workflowTemplateRef) {
  const templateName = cronWorkflow.spec.workflowSpec.workflowTemplateRef.name;
  const clusterScope = cronWorkflow.spec.workflowSpec.workflowTemplateRef.clusterScope;
- const url: string = clusterScope ? `/cluster-workflow-templates/${templateName}` : `/workflow-templates/${cronWorkflow.metadata.namespace}/${templateName}`;
+ const url: string = clusterScope ? uiUrl(`cluster-workflow-templates/${templateName}`) : uiUrl(`workflow-templates/${cronWorkflow.metadata.namespace}/${templateName}`);
  const icon: string = clusterScope ? 'fa fa-window-restore' : 'fa fa-window-maximize';
 
  const templateLink: Link = {

diff --git a/ui/src/app/workflows/components/workflow-details/workflow-details.tsx b/ui/src/app/workflows/components/workflow-details/workflow-details.tsx
@@ -211,7 +211,7 @@ export const WorkflowDetails = ({history, location, match}: RouteComponentProps<
  if (workflow?.spec?.workflowTemplateRef) {
  const templateName: string = workflow.spec.workflowTemplateRef.name;
  const clusterScope: boolean = workflow.spec.workflowTemplateRef.clusterScope;
- const url: string = clusterScope ? `/cluster-workflow-templates/${templateName}` : `/workflow-templates/${workflow.metadata.namespace}/${templateName}`;
+ const url: string = clusterScope ? uiUrl(`cluster-workflow-templates/${templateName}`) : uiUrl(`workflow-templates/${workflow.metadata.namespace}/${templateName}`);
  const icon: string = clusterScope ? 'fa fa-window-restore' : 'fa fa-window-maximize';
 
  const templateLink: Link = {