fix(executor): Do not make unneeded get pod when no sidecars (#5161)

Signed-off-by: Alex Collins <[email protected]>

Makefile

@@ -350,7 +350,7 @@ dist/kustomize:
  dist/kustomize version
 
 # generates several installation files
-manifests/install.yaml: $(CRDS) dist/kustomize
+manifests/install.yaml: $(MANIFESTS) dist/kustomize
  ./hack/update-image-tags.sh manifests/base $(VERSION)
  dist/kustomize build --load_restrictor=none manifests/cluster-install | ./hack/auto-gen-msg.sh > manifests/install.yaml
  dist/kustomize build --load_restrictor=none manifests/namespace-install | ./hack/auto-gen-msg.sh > manifests/namespace-install.yaml
@@ -386,10 +386,12 @@ install: $(MANIFESTS) $(E2E_MANIFESTS) dist/kustomize
  kubectl config set-context --current --namespace=$(KUBE_NAMESPACE)
  @echo "installing PROFILE=$(PROFILE) VERSION=$(VERSION), E2E_EXECUTOR=$(E2E_EXECUTOR)"
  dist/kustomize build --load_restrictor=none test/e2e/manifests/$(PROFILE) | sed 's/argoproj\//$(IMAGE_NAMESPACE)\//' | sed 's/:latest/:$(VERSION)/' | sed 's/containerRuntimeExecutor: docker/containerRuntimeExecutor: $(E2E_EXECUTOR)/' | kubectl -n $(KUBE_NAMESPACE) apply --prune -l app.kubernetes.io/part-of=argo -f -
+ifeq ($(PROFILE),stress)
  kubectl -n $(KUBE_NAMESPACE) apply -f test/stress/massive-workflow.yaml
  kubectl -n $(KUBE_NAMESPACE) rollout restart deploy workflow-controller
  kubectl -n $(KUBE_NAMESPACE) rollout restart deploy argo-server
  kubectl -n $(KUBE_NAMESPACE) rollout restart deploy minio
+endif
 ifeq ($(RUN_MODE),kubernetes)
  # scale to 2 replicas so we touch upon leader election
  kubectl -n $(KUBE_NAMESPACE) scale deploy/workflow-controller --replicas 2

hack/test-examples.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 set -eu -o pipefail
 
-kubectl delete wf -l workflows.argoproj.io/test
+./dist/argo delete -l workflows.argoproj.io/test
 
 grep -lR 'workflows.argoproj.io/test' examples/* | while read f ; do
  ./dist/argo submit --watch --verify $f

workflow/executor/executor.go

@@ -1075,6 +1075,9 @@ func (we *WorkflowExecutor) monitorDeadline(ctx context.Context, containerNames
 // KillSidecars kills any sidecars to the main container
 func (we *WorkflowExecutor) KillSidecars(ctx context.Context) error {
  sidecarNames := we.Template.GetSidecarNames()
+ if len(sidecarNames) == 0 {
+ return nil // exit early as GetTerminationGracePeriodDuration performs `get pod`
+ }
  log.Infof("Killing sidecars %s", strings.Join(sidecarNames, ","))
  terminationGracePeriodDuration, _ := we.GetTerminationGracePeriodDuration(ctx)
  return we.RuntimeExecutor.Kill(ctx, sidecarNames, terminationGracePeriodDuration)