fix(controller): Performance improvement for Sprig. Fixes #6135 (#6140)

argoproj · Jun 14, 2021 · 8059932 · 8059932
1 parent 868868e
commit 8059932
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/util/expr/env/env.go b/util/expr/env/env.go
@@ -4,19 +4,25 @@ import (
  "encoding/json"
 
  "github.com/Masterminds/sprig"
+
  exprpkg "github.com/argoproj/pkg/expr"
  "github.com/doublerebel/bellows"
 )
 
+var sprigFuncMap = sprig.GenericFuncMap() // a singleton for better performance
+
+func init() {
+ delete(sprigFuncMap, "env")
+ delete(sprigFuncMap, "expandenv")
+}
+
 func GetFuncMap(m map[string]interface{}) map[string]interface{} {
  env := bellows.Expand(m)
  for k, v := range exprpkg.GetExprEnvFunctionMap() {
  env[k] = v
  }
- delete(env, "env")
- delete(env, "expandenv")
  env["toJson"] = toJson
- env["sprig"] = sprig.GenericFuncMap()
+ env["sprig"] = sprigFuncMap
  return env
 }