Added hint when using certain tokens in when expressions (#1810)

* Added hint when using certain tokens in when expressions * Minor
argoproj · Dec 5, 2019 · 400274f · 400274f
1 parent 15a0aa7
commit 400274f
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/workflow/controller/steps.go b/workflow/controller/steps.go
@@ -255,6 +255,9 @@ func shouldExecute(when string) (bool, error) {
  }
  expression, err := govaluate.NewEvaluableExpression(when)
  if err != nil {
+ if strings.Contains(err.Error(), "Invalid token") {
+ return false, errors.Errorf(errors.CodeBadRequest, "Invalid 'when' expression '%s': %v (hint: try wrapping the affected expression in quotes (\"))", when, err)
+ }
  return false, errors.Errorf(errors.CodeBadRequest, "Invalid 'when' expression '%s': %v", when, err)
  }
  // The following loop converts govaluate variables (which we don't use), into strings. This