fix(executor): Remove IsTransientErr check for ExponentialBackoff. Fixes

#4144 (#4149)
argoproj · Oct 2, 2020 · 2b12762 · 2b12762
1 parent f7e85f0
commit 2b12762
Showing 1 changed file with 0 additions and 10 deletions.
diff --git a/workflow/executor/executor.go b/workflow/executor/executor.go
@@ -32,7 +32,6 @@ import (
  wfv1 "github.com/argoproj/argo/pkg/apis/workflow/v1alpha1"
  "github.com/argoproj/argo/util"
  "github.com/argoproj/argo/util/archive"
- errorsutil "github.com/argoproj/argo/util/errors"
  "github.com/argoproj/argo/util/retry"
  artifact "github.com/argoproj/argo/workflow/artifacts"
  "github.com/argoproj/argo/workflow/common"
@@ -619,9 +618,6 @@ func (we *WorkflowExecutor) getPod() (*apiv1.Pod, error) {
  pod, err = podsIf.Get(we.PodName, metav1.GetOptions{})
  if err != nil {
  log.Warnf("Failed to get pod '%s': %v", we.PodName, err)
- if !errorsutil.IsTransientErr(err) {
- return false, err
- }
  return false, nil
  }
  return true, nil
@@ -646,9 +642,6 @@ func (we *WorkflowExecutor) GetConfigMapKey(name, key string) (string, error) {
  configmap, err = configmapsIf.Get(name, metav1.GetOptions{})
  if err != nil {
  log.Warnf("Failed to get configmap '%s': %v", name, err)
- if !errorsutil.IsTransientErr(err) {
- return false, err
- }
  return false, nil
  }
  return true, nil
@@ -681,9 +674,6 @@ func (we *WorkflowExecutor) GetSecrets(namespace, name, key string) ([]byte, err
  secret, err = secretsIf.Get(name, metav1.GetOptions{})
  if err != nil {
  log.Warnf("Failed to get secret '%s': %v", name, err)
- if !errorsutil.IsTransientErr(err) {
- return false, err
- }
  return false, nil
  }
  return true, nil