fix(ui): handle non-existent labels in isWorkflowInCluster (#12898)

Signed-off-by: Anton Gilgur <[email protected]>
argoproj · Apr 21, 2024 · 08772fb · 08772fb
1 parent 49e21ac
commit 08772fb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/ui/src/app/workflows/components/workflow-details/workflow-details.tsx b/ui/src/app/workflows/components/workflow-details/workflow-details.tsx
@@ -375,7 +375,7 @@ export function WorkflowDetails({history, location, match}: RouteComponentProps<
  if (e.type === 'DELETED') {
  setUid(e.object.metadata.uid);
  setError(new Error('Workflow gone'));
- if (e.object.metadata.labels[archivalStatus]) {
+ if (e.object.metadata.labels?.[archivalStatus]) {
  e.object.metadata.labels[archivalStatus] = 'Persisted';
  }
  setWorkflow(e.object);

diff --git a/ui/src/models/workflows.ts b/ui/src/models/workflows.ts
@@ -545,7 +545,9 @@ export function isWorkflowInCluster(wf: Workflow): boolean {
  if (!wf) {
  return false;
  }
- return !wf.metadata.labels[archivalStatus] || wf.metadata.labels[archivalStatus] === 'Pending' || wf.metadata.labels[archivalStatus] === 'Archived';
+
+ const labelValue = wf.metadata?.labels?.[archivalStatus];
+ return !labelValue || labelValue === 'Pending' || labelValue === 'Archived';
 }
 
 export function isArchivedWorkflow(wf?: Workflow): boolean {