Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): add ImagePullPolicy to repo server init container #1228

Merged
merged 1 commit into from
Apr 19, 2022
Merged

feat(argo-cd): add ImagePullPolicy to repo server init container #1228

merged 1 commit into from
Apr 19, 2022

Conversation

franklinkim
Copy link
Contributor

Adds ImagePullPolicy for the repo-server init container

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Changes are automatically published when merged to master. They are not published on branches.

@franklinkim
feat(argo-cd): add ImagePullPolicy
648c09c 
Adds ImagePullPolicy to the repo-server init container

Signed-off-by: Kevin Franklin Kim <[email protected]>
@mbevc1 mbevc1 added the argo-cd label Apr 19, 2022
davidkarlsen
davidkarlsen approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@davidkarlsen davidkarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidkarlsen davidkarlsen merged commit 5d6442b into argoproj:master Apr 19, 2022
@franklinkim franklinkim deleted the feature/add-repo-server-image-pull-policy branch April 19, 2022 11:41
@mkilchhofer mkilchhofer linked an issue Apr 22, 2022 that may be closed by this pull request
add missing imagePullPolicy on argocd-repo-server/deployment (initContainers) #1227
Closed
@mkilchhofer mkilchhofer mentioned this pull request Apr 22, 2022
Closed
terrych0u pushed a commit to terrych0u/argo-helm that referenced this pull request Aug 4, 2022
@franklinkim @terrych0u
feat(argo-cd): add ImagePullPolicy to repo server init container (arg…
959cce1 
…oproj#1228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkarlsen davidkarlsen davidkarlsen approved these changes

@yann-soubeyrand yann-soubeyrand Awaiting requested review from yann-soubeyrand

@mbevc1 mbevc1 Awaiting requested review from mbevc1

Assignees
No one assigned
Labels
argo-cd size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add missing imagePullPolicy on argocd-repo-server/deployment (initContainers)
3 participants
@franklinkim @davidkarlsen @mbevc1