Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update gitops-engine to get the fix for sync should apply Namesp… #5556

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

mayzhang2000
Copy link
Contributor

…aces and CRDs before resources

Signed-off-by: May Zhang [email protected]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #5556 (ce62b05) into master (6de3cf4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5556   +/-   ##
=======================================
  Coverage   40.98%   40.98%           
=======================================
  Files         144      144           
  Lines       19047    19047           
=======================================
  Hits         7807     7807           
  Misses      10146    10146           
  Partials     1094     1094           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de3cf4...ce62b05. Read the comment docs.

@mayzhang2000 mayzhang2000 merged commit 594c827 into argoproj:master Feb 19, 2021
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
argoproj#5556)

* fix: Update gitops-engine to get the fix for sync should apply Namespaces and CRDs before resources

Signed-off-by: May Zhang <[email protected]>

* fix: Update gitops-engine to get the fix for sync should apply Namespaces and CRDs before resources

Signed-off-by: May Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants