feat(opentelemetry): ✨ support for secured OTLP endpoint and headers #15573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prashant Shahi <[email protected]>
Signed-off-by: Prashant Shahi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15573 +/- ##
==========================================
+ Coverage 49.53% 49.55% +0.02%
==========================================
Files 269 269
Lines 47222 47243 +21
==========================================
+ Hits 23392 23413 +21
Misses 21530 21530
Partials 2300 2300 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Prashant Shahi <[email protected]>
Signed-off-by: Prashant Shahi <[email protected]>
Signed-off-by: Prashant Shahi <[email protected]>
Signed-off-by: Prashant Shahi <[email protected]>
Signed-off-by: Prashant Shahi <[email protected]>
docs/operator-manual/server-commands/argocd-application-controller.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Prashant Shahi <[email protected]>
|
@blakepettersson Thanks for the review. |
gdsoumya
requested changes
Nov 24, 2023
| @@ -206,6 +208,8 @@ func NewCommand() *cobra.Command { | |||
| command.Flags().BoolVar(&repoServerStrictTLS, "repo-server-strict-tls", env.ParseBoolFromEnv("ARGOCD_APPLICATION_CONTROLLER_REPO_SERVER_STRICT_TLS", false), "Whether to use strict validation of the TLS cert presented by the repo server") | |||
| command.Flags().StringSliceVar(&metricsAplicationLabels, "metrics-application-labels", []string{}, "List of Application labels that will be added to the argocd_application_labels metric") | |||
| command.Flags().StringVar(&otlpAddress, "otlp-address", env.StringFromEnv("ARGOCD_APPLICATION_CONTROLLER_OTLP_ADDRESS", ""), "OpenTelemetry collector address to send traces to") | |||
| command.Flags().BoolVar(&otlpInsecure, "otlp-insecure", env.ParseBoolFromEnv("ARGOCD_APPLICATION_CONTROLLER_OTLP_INSECURE", true), "OpenTelemetry collector insecure mode") | |||
| command.Flags().StringToStringVar(&otlpHeaders, "otlp-headers", env.ParseStringToStringFromEnv("ARGOCD_SERVER_OTLP_HEADERS", map[string]string{}, ","), "List of OpenTelemetry collector extra headers sent with traces, headers are comma-separated key-value pairs(e.g. key1=value1,key2=value2)") | |||
There was a problem hiding this comment.
@gdsoumya updated
Signed-off-by: Prashant Shahi <[email protected]>
gdsoumya
approved these changes
Nov 24, 2023
|
@prashant-shahi codegen ci step is failing can you run |
Signed-off-by: Prashant Shahi <[email protected]>
|
@gdsoumya Thanks a lot for the review! 🎉 |
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
…rgoproj#15573) * feat(opentelemetry): ✨ support for secured OTLP endpoint and headers Signed-off-by: Prashant Shahi <[email protected]> * docs(opentelemetry): 📝 include new otlp headers in docs Signed-off-by: Prashant Shahi <[email protected]> * docs(opentelemetry): 📝 update readme docs as per integration tests Signed-off-by: Prashant Shahi <[email protected]> * docs(opentelemetry): 📝 update readme docs as per integration tests Signed-off-by: Prashant Shahi <[email protected]> * chore: resolve indentation issues Signed-off-by: Prashant Shahi <[email protected]> * chore: fix indentation issues Signed-off-by: Prashant Shahi <[email protected]> * chore: include OTLP options in deployment manifests Signed-off-by: Prashant Shahi <[email protected]> * fix: update manifests to resolve failing CI Signed-off-by: Prashant Shahi <[email protected]> --------- Signed-off-by: Prashant Shahi <[email protected]>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…rgoproj#15573) * feat(opentelemetry): ✨ support for secured OTLP endpoint and headers Signed-off-by: Prashant Shahi <[email protected]> * docs(opentelemetry): 📝 include new otlp headers in docs Signed-off-by: Prashant Shahi <[email protected]> * docs(opentelemetry): 📝 update readme docs as per integration tests Signed-off-by: Prashant Shahi <[email protected]> * docs(opentelemetry): 📝 update readme docs as per integration tests Signed-off-by: Prashant Shahi <[email protected]> * chore: resolve indentation issues Signed-off-by: Prashant Shahi <[email protected]> * chore: fix indentation issues Signed-off-by: Prashant Shahi <[email protected]> * chore: include OTLP options in deployment manifests Signed-off-by: Prashant Shahi <[email protected]> * fix: update manifests to resolve failing CI Signed-off-by: Prashant Shahi <[email protected]> --------- Signed-off-by: Prashant Shahi <[email protected]>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
…rgoproj#15573) * feat(opentelemetry): ✨ support for secured OTLP endpoint and headers Signed-off-by: Prashant Shahi <[email protected]> * docs(opentelemetry): 📝 include new otlp headers in docs Signed-off-by: Prashant Shahi <[email protected]> * docs(opentelemetry): 📝 update readme docs as per integration tests Signed-off-by: Prashant Shahi <[email protected]> * docs(opentelemetry): 📝 update readme docs as per integration tests Signed-off-by: Prashant Shahi <[email protected]> * chore: resolve indentation issues Signed-off-by: Prashant Shahi <[email protected]> * chore: fix indentation issues Signed-off-by: Prashant Shahi <[email protected]> * chore: include OTLP options in deployment manifests Signed-off-by: Prashant Shahi <[email protected]> * fix: update manifests to resolve failing CI Signed-off-by: Prashant Shahi <[email protected]> --------- Signed-off-by: Prashant Shahi <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…rgoproj#15573) * feat(opentelemetry): ✨ support for secured OTLP endpoint and headers Signed-off-by: Prashant Shahi <[email protected]> * docs(opentelemetry): 📝 include new otlp headers in docs Signed-off-by: Prashant Shahi <[email protected]> * docs(opentelemetry): 📝 update readme docs as per integration tests Signed-off-by: Prashant Shahi <[email protected]> * docs(opentelemetry): 📝 update readme docs as per integration tests Signed-off-by: Prashant Shahi <[email protected]> * chore: resolve indentation issues Signed-off-by: Prashant Shahi <[email protected]> * chore: fix indentation issues Signed-off-by: Prashant Shahi <[email protected]> * chore: include OTLP options in deployment manifests Signed-off-by: Prashant Shahi <[email protected]> * fix: update manifests to resolve failing CI Signed-off-by: Prashant Shahi <[email protected]> --------- Signed-off-by: Prashant Shahi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for sending Argo CD traces to secured OTLP endpoint along with the custom headers.
These can be configured with the help of these flags:
--otlp-headerand--otlp-insecure.Fixes #12310 (proposal by @mtsvyatkovski)
Fixes #13927 (proposal by @bencompton)
Checklist:
Signed-off-by: Prashant Shahi [email protected]