Fix pip cython alt #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: * setup.py long_description, using contents of README.md. * setup_requires with setuptools and wheel. * MANIFEST.in file to include relevant files in sdist tarball. * Missing license info. Changed: * Import from setuptools instead of distutils to enable building wheels. Fixed: * Fixes aresch#11 pip cython requirement issue by generating `.c` with sdist. Removed: * Unneeded setup.cfg file.
aresch
approved these changes
Sep 20, 2018
|
Maybe a setup.py option to force a build from a dist not to use cython would be helpful. If a user has cython installed for his own needs, he may wish to just use the distributed .c rather than spin extra cycles using cython/.pyx to build. I don't have a patch yet - just inquiring at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #18 that does not require cython to build from source distribution.
Added:
Changed:
wheels.
Fixed:
.cwith sdist.Removed: