Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest dev b8dfc6b compile error #5544

Closed
1 task
DavidFW1960 opened this issue Mar 28, 2019 · 10 comments
Closed
1 task

Latest dev b8dfc6b compile error #5544

DavidFW1960 opened this issue Mar 28, 2019 · 10 comments
Labels
fixed Result - The work on the issue has ended troubleshooting Type - Troubleshooting

Comments

@DavidFW1960
Copy link

BUG DESCRIPTION

A clear and concise description of what the bug is.

Compiling latest dev b8dfc6b

Errors:

C:/Users/david/Documents/Sonoff-Tasmota/Sonoff-Tasmota-development b8dfc6b/sonoff/settings.ino: In function 'void SettingsDefaultSet2()':
C:/Users/david/Documents/Sonoff-Tasmota/Sonoff-Tasmota-development b8dfc6b/sonoff/settings.ino:818:29: error: 'WORKING_PERIOD' was not declared in this scope
Settings.novasds_period = WORKING_PERIOD;
^
C:/Users/david/Documents/Sonoff-Tasmota/Sonoff-Tasmota-development b8dfc6b/sonoff/settings.ino: In function 'void SettingsDelta()':
C:/Users/david/Documents/Sonoff-Tasmota/Sonoff-Tasmota-development b8dfc6b/sonoff/settings.ino:1061:33: error: 'WORKING_PERIOD' was not declared in this scope
Settings.novasds_period = WORKING_PERIOD;

REQUESTED INFORMATION

Make sure these boxes are checked before submitting your issue. Thank you

FAILURE TO COMPLETE THE REQUESTED INFORMATION WILL RESULT IN YOUR ISSUE BEING CLOSED

STATUS 0 OUTPUT HERE:


  • Provide the output of console when you experience your issue if apply :
    (Please use weblog 4 for more debug information)
CONSOLE OUTPUT HERE:


TO REPRODUCE

Steps to reproduce the behavior:

EXPECTED BEHAVIOUR

A clear and concise description of what you expected to happen.

SCREENSHOTS

If applicable, add screenshots to help explain your problem.

ADDITIONAL CONTEXT

Add any other context about the problem here.

(Please, remember to close the issue when the problem has been addressed)

@ascillato
Copy link
Contributor

Hi,

Sorry, I could not reproduce it. Besides Tasmota is passing Travis compilation ok for all languages and version explicited in platformio.ini file (see compilation badge in readme)

Please, try to erase all files and download again in a fresh folder. Thanks

@DavidFW1960
Copy link
Author

I did that Adrian... I always download the full zip file to a fresh folder. I'll try again.

@DavidFW1960
Copy link
Author

I downloaded again and got the exact same result.
I also re-compiled the firmware from a couple of days ago and got no error.

I always download the fill zip file and unzip to a new folder and then make the necessary changes in my_user_config.h and platformio.ini
This has always worked.... (the 6.4.1.x problem excepted)

@wongnam
Copy link

wongnam commented Mar 29, 2019

I only saw this, no other compile error. VSC with PlatformIO IDE

image

@DavidFW1960
Copy link
Author

Same error it seems and compilation fails...

@Jason2866
Copy link
Collaborator

There is no error when compiling latest dev version using VSC.
Your setup has to be faulty.
image
@wongnam
This is just a cosmetic issue. Fixed with open PR #5524

@arendst
Copy link
Owner

arendst commented Mar 29, 2019

Define WORKING_PERIOD 5 should be in your my_user_config.h file.

As of the introduction of command Sensor20 yesterday it is mandatory. For those who commented it out I'll re-add it to settings.ino someday...

@DavidFW1960
Copy link
Author

Ah. Thanks. I’ll take a look at that. That would explain it. I’ll confirm tomorrow.

arendst added a commit that referenced this issue Mar 30, 2019
Fix compile error (#5544)
@arendst arendst added the fixed Result - The work on the issue has ended label Mar 30, 2019
@ascillato2
Copy link
Collaborator

Closing issue as it is not a Tasmota bug.

Please, if you need further assistant, address this to the Tasmota Support Chat. The chat is a better and more dynamic channel for helping you.

Thanks.


Support Information

See Wiki for more information.
See Chat for more user experience.
See Community for forum.
See Code of Conduct

@ascillato2 ascillato2 added the troubleshooting Type - Troubleshooting label Mar 30, 2019
@DavidFW1960
Copy link
Author

Seems @arendst has added it back in settings.ino already. Thanks... it's now compiling with latest dev branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Result - The work on the issue has ended troubleshooting Type - Troubleshooting
Projects
None yet
Development

No branches or pull requests

6 participants