Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can provide extension for I2C ADS1115. Intrested? #338

Closed
stefanbode opened this issue Apr 6, 2017 · 8 comments
Closed

I can provide extension for I2C ADS1115. Intrested? #338

stefanbode opened this issue Apr 6, 2017 · 8 comments

Comments

@stefanbode
Copy link
Contributor

I created a new file xsns_ads1115.ino linked on demand to support 16bit 4-channel A/D converter. Mr. Arend, interested in adding. Library used: Adafruit_ADS1X15-master

Code +1kb, Ram +968Byte.

@ionciubotaru
Copy link

Test your code carefully and add a pull request. @arendst will decide or not to include it in the next release. Adding new features is good for community.

@PitPaul
Copy link

PitPaul commented Apr 15, 2017

Hey , can you send code to test it ?

@stefanbode
Copy link
Contributor Author

Take a look at the forks that where created. You should easily find mine with the additions. Let me know if you got problems. worked for me excellent. I do not transfer the voltage, just the pure digital output. Any postprocessing should be done in the application.

@davidelang
Copy link
Collaborator

please provide a link to the fork in question

@davidelang
Copy link
Collaborator

or ideally, create a pull request for the proposed changes.

@stefanbode
Copy link
Contributor Author

Hi David. You can reach me on skype. stefan.bode. The fork you will find here: https://github.com/stefanbode/Sonoff-Tasmota/tree/master/sonoff

@davidelang
Copy link
Collaborator

taking a very quick look at this, could you please create a couple branches with subsets of these changes

  1. back out the user_config.h changes (I suggest using user_config_override.h locally so that you don't keep fighting this issue)

  2. you have added several libraries. I believe that we would prefer to not have the libraries in our git tree and instead add them to the prereq list so that they are maintained and updated outside of tasmota. We only include libraries when we have a need to use a specific version and don't want to have them updated automatically.

  3. it looks like you are adding two different sensors here. Having a separate branch that is specific to each sensor makes it easier to review and merge

Once you do this cleanup, please create a pull request for each of these sensors and in the pull request, document how much additional flash and ram each one adds

@fdsailer
Copy link

fdsailer commented Nov 4, 2017

Hello Everybody
I would be very interested into the support for the ADS1115. Is there a specific plan to support or has the good idee vanished ? If somebody can give me a insight ?

Thanks

Michael

arendst added a commit that referenced this issue Nov 7, 2017
5.9.0b
 * Add support for ADS1115 to be enabled in user_config.h and
needs libraries i2cdevlib-Core and i2cdevlib-ADS1115 (#338, #660)
 * Fix
Exception 26 and empty console screen after usage of command
WakeupDuration (#1133)
 * Fix some changed iTead web links in README.md
(#1137)
arendst added a commit that referenced this issue Nov 7, 2017
5.9.1 20171107
 * Add external sensor function pointer interface to
enable easy sensor addition
 * Add support for ADS1115 to be enabled in
user_config.h and needs libraries i2cdevlib-Core and i2cdevlib-ADS1115
(#338, #660)
 * Fix Backup Configuration file download failure by
defining proper file size (#1115)
 * Fix Exception 26 and empty console
screen after usage of command WakeupDuration (#1133)
 * Fix some changed
iTead web links in README.md (#1137)
@arendst arendst closed this as completed Nov 7, 2017
curzon01 pushed a commit to curzon01/Tasmota that referenced this issue Sep 6, 2018
5.9.0b
 * Add support for ADS1115 to be enabled in user_config.h and
needs libraries i2cdevlib-Core and i2cdevlib-ADS1115 (arendst#338, arendst#660)
 * Fix
Exception 26 and empty console screen after usage of command
WakeupDuration (arendst#1133)
 * Fix some changed iTead web links in README.md
(arendst#1137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants