Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~ | Services - Form::hasSideForm: side form is not shown if it only contains fieldsets #2234

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Conversation

agnonym
Copy link
Contributor

@agnonym agnonym commented Apr 15, 2023

No description provided.

@ifox
Copy link
Member

ifox commented Apr 15, 2023

Thanks for all your contribution @agnonym!

Please check if this PR is addressing the same issue, if not, it'd be great to address both in the same PR.

@agnonym
Copy link
Contributor Author

agnonym commented Apr 15, 2023

Hmm... not sure #2230 fixes the problem as it checks if the main form is empty... meaning hasSideForm is true if you have fields in the main form. (I tried its code, if I have no field in the main form, my side form fieldset is not shown).

My guess is both PR address the same issue, but... maybe should you make up your own mind on how it should be addressed 🤔

@agnonym
Copy link
Contributor Author

agnonym commented Apr 15, 2023

Thanks for all your contribution @agnonym!

It's just small participations! Thank you for all the work done on this new version

@EpicKau
Copy link

EpicKau commented Apr 15, 2023

@ifox @agnonym My bad, my code was using $this->isNotEmpty() but that referenced to the main form and not the side form.
It should be
$this->sideForm->fieldsets && $this->sideForm->fieldsets->isNotEmpty()
So @agnonym is right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants