Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1207: Forward the realTimeDiagnostics to the LS. #1208

Merged
merged 1 commit into from
Jul 18, 2022
Merged

#1207: Forward the realTimeDiagnostics to the LS. #1208

merged 1 commit into from
Jul 18, 2022

Conversation

kittaakos
Copy link
Contributor

Motivation

The arduino.language.realTimeDiagnostics preference value was not forwarded to the LS; hence it's always published the diagnostics to the IDE2.

Change description

Other information

Closes #1207.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos requested review from fstasi and per1234 July 18, 2022 14:03
fstasi
fstasi approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@fstasi fstasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

per1234
per1234 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #1207 for me. Thanks Akos!

@kittaakos kittaakos merged commit d4833af into main Jul 18, 2022
@kittaakos kittaakos deleted the #1207 branch July 18, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@fstasi fstasi fstasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arduino.language.realTimeDiagnostics setting has no effect
3 participants
@kittaakos @fstasi @per1234