Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using useContentSize when creating a new window #1197

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Avoid using useContentSize when creating a new window #1197

merged 1 commit into from
Jul 18, 2022

Conversation

AlbyIanna
Copy link
Contributor

Motivation

#1184

Change description

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@per1234 per1234 linked an issue Jul 16, 2022 that may be closed by this pull request
IDE's window height is incorrectly preserved/restored between sessions #1184
Closed
3 tasks
kittaakos
kittaakos approved these changes Jul 17, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified it on macOS; it worked for me. 👍

@AlbyIanna AlbyIanna merged commit 99664ee into main Jul 18, 2022
@AlbyIanna AlbyIanna deleted the restore-window-height branch July 18, 2022 08:46
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

@fstasi fstasi fstasi approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IDE's window height is incorrectly preserved/restored between sessions
4 participants
@AlbyIanna @kittaakos @fstasi @per1234