Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update themes #1187

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Update themes #1187

merged 1 commit into from
Jul 15, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@per1234 per1234 added the topic: theme Related to GUI theming label Jul 14, 2022
@kittaakos
Copy link
Contributor

Is this for #1180, @91volt?

It looks great. The Theia dark theme is not the best, but the rest looks great. 😍 Thank you for the fix!

button_background.mp4

AlbyIanna
AlbyIanna approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This doesn't seem enough to fix #1180 though, because it shows the yellow button only when pressing "Verify" and not when pressing "Upload".
I'll open a separate PR to solve that since this PR is the auto-generated one for updating theme colors.

About the High Contrast and Theia themes, we're having a discussion about it and we're probably going to solve it separately.

@per1234
Copy link
Contributor

per1234 commented Jul 15, 2022

it shows the yellow button only when pressing "Verify" and not when pressing "Upload"

The bug is being tracked here @AlbyIanna: #173 (comment)

@AlbyIanna
Copy link
Contributor

it shows the yellow button only when pressing "Verify" and not when pressing "Upload"

The bug is being tracked here @AlbyIanna: #173 (comment)

Ah! #1180 is only referring to the Verify button. My bad!

@AlbyIanna AlbyIanna merged commit 1514d01 into main Jul 15, 2022
@AlbyIanna AlbyIanna deleted the themes/themes-update branch July 15, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Assignees
No one assigned
Labels
topic: theme Related to GUI theming
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kittaakos @per1234 @AlbyIanna