upload: do not give up if no port is specified for 1200 bps touch #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchinm
approved these changes
Apr 13, 2021
silvanocerza
approved these changes
Apr 13, 2021
cb007e8
to
19f792c
Compare
silvanocerza
pushed a commit
that referenced
this pull request
Apr 13, 2021
…bps-touch on the serial port (#1263)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some particular boards where the serial port is required only to switch the board in bootloader mode but the actual upload is performed in other ways.
This patch allows to upload when the board is already in bootloader mode, otherwise, the cli will exit with the error:
Previously the CLI would exit with an error anyway, so this change should not make any harm to other boards.