Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFiS3: Skip unaligned responses from WiFi chip #353

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Jul 22, 2024

When network goes down (WiFi is up but no internet connection) AT message parsing gets corrupted due to late reply from WiFi chip. This PR fixes the issue discarding unaligned responses from WiFi chip .

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Aug 3, 2024
@pennam
Copy link
Contributor Author

pennam commented Aug 7, 2024

superseded by #349

@pennam pennam closed this Aug 7, 2024
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Aug 7, 2024
@pennam
Copy link
Contributor Author

pennam commented Aug 14, 2024

Re-opening because #349 needs a fix in the WiFi firmware

@pennam pennam reopened this Aug 14, 2024
@per1234 per1234 removed the conclusion: duplicate Has already been submitted label Aug 14, 2024
@pennam
Copy link
Contributor Author

pennam commented Aug 19, 2024

Testing core sketches using AT commands:
OTA 👍
StartCounter 👍
Prefs2Struct 👍
SATSECertificate 👍
SATSEPrivateKey 👍
SATSERandomNumber 👍
SATSESerialNumber 👍
SATSESignAndVerify 👍
WiFiWebServer 👍
WiFiWebClientSSL 👍
WiFiWebClientRepeating 👍
WiFiWebClient 👍
WiFiUdpNtpClient 👍
WiFiPagerServer 👍
WiFiChatServer Reads only first char, also released core
WiFiAdvancedChatServer No echo, also released core
SimpleWebServerWiFi 👍
ScanNetworksAdvanced 👍
ScanNetworks 👍
ConnectWithWPA 👍
AP_SimpleWebServer 👍

@pennam pennam merged commit 1564d0a into arduino:main Aug 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants