Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 6 year old bug in ipaddress.h #28

Closed
wants to merge 1 commit into from

Conversation

Rotzbua
Copy link

@Rotzbua Rotzbua commented Aug 1, 2018

This bug causes multiple sram usage. Now only one instance should be in sram.

fix arduino/Arduino#1007

@matthijskooijman
Copy link
Collaborator

I wonder if this would be better fixed by making the declaration in the .h file constexpr and give it a value there. I believe that, to allow taking the address of the constant, it still needs a definition in the .cpp file as introduced by this PR, but then the definition does not need to assign a value.

@facchinm
Copy link
Member

Fixed by arduino/ArduinoCore-API@3dbd7d7 (as soon as AVR core will be based on chainsaw the patch will be applied here as well)

@aentinger
Copy link
Contributor

Closing this issue since initial port of Arduino API has been done and this issue is fixed with arduino/ArduinoCore-API@3dbd7d7 as noted by @facchinm .

@aentinger aentinger closed this Sep 16, 2019
@Rotzbua Rotzbua deleted the fix_extern branch November 3, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple instances of INADDR_NONE [imported]
4 participants