Support for Laravel 8 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stancl
requested changes
Sep 9, 2020
composer.json
Outdated
| "phpunit/phpunit": "^8.0", | ||
| "orchestra/testbench": "^5.1" | ||
| "phpunit/phpunit": "^8.4|^9.0", | ||
| "orchestra/testbench": "^6.0" |
There was a problem hiding this comment.
Please add a | here rather than changing the major version
composer.json
Outdated
| @@ -20,11 +20,11 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": "^7.2", | |||
| "illuminate/database": "^6.0|^7.0" | |||
| "php": "^7.3", | |||
There was a problem hiding this comment.
Laravel 7.x still supports PHP 7.2
composer.json
Outdated
| "php": "^7.2", | ||
| "illuminate/database": "^6.0|^7.0" | ||
| "php": "^7.3", | ||
| "illuminate/database": "^8.0" |
|
Also tests should now run in a matrix for both L7 and L8 |
I'm not sure that this is the right way as I have no experience with Travis.
stancl
approved these changes
Sep 9, 2020
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "^8.0", | ||
| "orchestra/testbench": "^5.1" | ||
| "phpunit/phpunit": "^8.4|^9.0", |
There was a problem hiding this comment.
What's the reasoning behind the ^8.4 change?
There was a problem hiding this comment.
Just wanted to be consistent with Laravel framework (versions 7.x and 8.x).
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.