Comparable enum #20
Merged
Comparable enum #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stancl
reviewed
Jun 8, 2023
stancl
reviewed
Jun 8, 2023
|
This would be great! What's blocking the merge and cutting a new release? |
|
@indytechcook Wasn't sure whether to add all the things included in this PR but I figured I'll just merge this. Updating some CI stuff now, noticed that tests were failing locally (PHP 8.3) so I added more PHP versions to the CI matrix. Seems like there's been a change in 8.2-8.3 that breaks some of our tests. Will fix that here and then merge this into master. Also dropped Laravel 9 in this PR. I think I'll tag v1.0.0 after merging this, since the package has been pretty stable so there's no reason to stay on 0.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @stancl ,
This PR implements comparable enum such as
is,isNot,inandnotInoperators.Thanks for the great package!