Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArangoDB Doc - Integration #512

Merged
merged 1 commit into from
Mar 6, 2018
Merged

ArangoDB Doc - Integration #512

merged 1 commit into from
Mar 6, 2018

Conversation

sleto-it
Copy link
Contributor

@sleto-it sleto-it commented Mar 3, 2018

@sleto-it sleto-it added the WIP label Mar 3, 2018
@sleto-it sleto-it requested review from pluma and Simran-B March 3, 2018 19:33
@pluma
Copy link
Contributor

pluma commented Mar 6, 2018

Is the folder structure necessary? It doesn't make sense to have the full structure in this repo:

docs/Drivers/JS/GettingStarted/README.md

The "Drivers/JS" part is redundant. Can the integration still work if we use "docs" as the root instead?

@dothebart
Copy link
Contributor

Hi @pluma,
the Idea was to replicate the structure under Documentation/Books/ so several targets can be addressed.

There is going to be a new Drivers Book, which is why we have Drivers here. The documents are to be placed in js which is why this has a place in the path.

@pluma
Copy link
Contributor

pluma commented Mar 6, 2018

@dothebart I understand that but the structure is highly redundant outside that specific context. This is a standalone repository for the arangojs driver. There aren't going to be any other driver docs in this repo. Is it possible to adjust the script so it knows to copy the arangojs docs folder into docs/Drivers/JS for the unified documentation?

Having two redundant layers of nesting in this repo increases the potential for errors, is confusing and makes maintenance more difficult.

@dothebart
Copy link
Contributor

You have to see the whole picture - It will not only be like this in this driver repo, but in any driver repo.
Once the structure is established (this pr accepted), you won't make this mistake anymore.

The alternative to this approach is to remove the documentation entirely over here, and only maintain it in the ArangoDB main repository.

@sleto-it
Copy link
Contributor Author

sleto-it commented Mar 6, 2018

Hi all,

I understand the full structure is redundant - we are trying to do the best to improve things (having the new book). Please let's accept the needed compromises, there always be ways to improve things

Thanks,

@pluma pluma merged commit 7777a25 into master Mar 6, 2018
@pluma pluma deleted the doc_integration branch March 6, 2018 20:49
@pluma
Copy link
Contributor

pluma commented Mar 6, 2018

I've rebased the PR and copied some of the content back into the README to make the yarn/npm package descriptions less useless. Let's see how this works out.

@sleto-it
Copy link
Contributor Author

sleto-it commented Mar 6, 2018

many thanks @pluma - appreciated

@pluma pluma added cla-available and removed WIP labels Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants