Support redirectToDefaultLang in static mode #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! Thanks a lot for the contribution @justincy ! LGTM! |
aralroca
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
Nice! Welcome as a contributor 🎉! LGTM, I'm going to merge it and deploy a canary release if you want to start using it in your code.
For the final version would be great to include redirectToDefaultLang on README explaining it how it works, + implementation for a custom server (middleware) + tests if it is possible. But this can be done in different PRs.
Maybe I get time during the weekend and I can help you with the rest 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #77. It worked locally for me.