Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow passing in a config to documentLang to avoid requiring "i18n.json" at request time #192

Merged
merged 1 commit into from
Jun 4, 2020
Merged

allow passing in a config to documentLang to avoid requiring "i18n.json" at request time #192

merged 1 commit into from
Jun 4, 2020

Conversation

lone-cloud
Copy link
Contributor

fixes #187

aralroca
aralroca approved these changes Jun 4, 2020
View reviewed changes
Copy link
Owner

@aralroca aralroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I thought exactly this as an alternative. Thanks!

@aralroca aralroca merged commit 546a049 into aralroca:master Jun 4, 2020
@aralroca aralroca added this to the 0.17.1 milestone Jun 4, 2020
@aralroca
Copy link
Owner

aralroca commented Jun 4, 2020

@all-contributors please add @lone-cloud for code

@allcontributors allcontributors bot mentioned this pull request Jun 4, 2020
Merged
@allcontributors
Copy link
Contributor

@aralroca

I've put up a pull request to add @lone-cloud! 🎉

@lone-cloud lone-cloud deleted the documentLang_optional_config branch June 4, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aralroca aralroca aralroca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.17.1
Development

Successfully merging this pull request may close these issues.

Build Error when using "documentLang" in TypeScript
2 participants
@lone-cloud @aralroca