Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to change the front page bundle #38

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

Marty
Copy link
Contributor

@Marty Marty commented Feb 1, 2022

To have the bundle "blog" be hard coded for the front page seemed a bit unflexible. Now you can define it in the config.

@apvarun
Copy link
Owner

apvarun commented Feb 4, 2022

Just thought about this change. I think it's better to have a default for frontBundle in code as well. Or else when current users update theme files and didn't add the property, the site will break.

{{ $frontBundle := cond (isset .Site.Params.frontBundle) .Site.Params.frontBundle "blog" }}

...


{{ range first 6 (where .Site.RegularPages.ByDate.Reverse "Type" $frontBundle)  }}

What do you think?

@Marty
Copy link
Contributor Author

Marty commented Feb 6, 2022

@apvarun Yes that makes sense, will do :)

@apvarun apvarun merged commit b489622 into apvarun:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants