feat: add aria-labels to nav elements #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CBID2 is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
2 tasks
TGlide
suggested changes
Nov 21, 2023
|
@CBID2 Thank you for the PR!! I left a few comments 🙂 |
|
Hi @TGlide! :) I made the changes you suggested! :) |
TGlide
reviewed
Nov 23, 2023
| @@ -26,7 +26,6 @@ | |||
| </script> | |||
|
|
|||
| <div class="aw-card is-normal u-margin-block-start-16" {...$root} use:root> | |||
| <nav class="tabs u-flex u-gap-16"> | |||
There was a problem hiding this comment.
Sorry, my wording was off here. By removing the nav element, I meant swapping it with something else, e.g. a div. Otherwise we lose the styling we had here.
|
Hi @TGlide! :) I made the changes! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an aria-label to
<nav>elements. This to make the site more accessible for users who use screen readers to navigate the site.Test Plan
To test this, I plan on using an accessiblity chrome extension to see if it conforms to accessibility standards.
Related PRs and Issues
Closes #294
Have you read the Contributing Guidelines on issues?
Yes