Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial for android java #271

Merged

Conversation

letsintegreat
Copy link

What does this PR do?

Closes #82

This PR adds a tutorial to /docs/tutorials/android

The tutorial gives a step-by-step guide to creating a recipe-sharing app - Recipewrite with Android and Java.

Test Plan

The final code can be found here, if you would like to test it.

Have you read the Contributing Guidelines on issues?

Yes.

@vercel
Copy link

vercel bot commented Oct 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2023 10:48am

@gewenyu99
Copy link
Contributor

Hi, can you give use the originals (unedited) of all your screenshots in light and dark more? Uncropped 16:9.

For console screenshots 1400x900

We'll also have to redo your other images, but we'll accept this without visuals.

Copy link
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I took my first look. Thank you so much for contributing to Appwrite, appreciate the effort you put in!

I have a few preliminary comments. Please take a look.

Love the idea, concerned about how complicated the auth components look :P

src/routes/docs/tutorials/android/step-5/+page.markdoc Outdated Show resolved Hide resolved
src/routes/docs/tutorials/android/step-2/+page.markdoc Outdated Show resolved Hide resolved
src/routes/docs/tutorials/android/step-2/+page.markdoc Outdated Show resolved Hide resolved
src/routes/docs/tutorials/android/step-2/+page.markdoc Outdated Show resolved Hide resolved
src/routes/docs/tutorials/android/step-2/+page.markdoc Outdated Show resolved Hide resolved
src/routes/docs/tutorials/android/step-4/+page.markdoc Outdated Show resolved Hide resolved
src/routes/docs/tutorials/android/step-4/+page.markdoc Outdated Show resolved Hide resolved
src/routes/docs/tutorials/android/step-4/+page.markdoc Outdated Show resolved Hide resolved
It will be used in **MainActivity** to check if the user is already logged in or not.

```java
public static void onGetAccount(Context context) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing imports. These should not be in Appwrite.js tbh. Why is there UI logic in Appwrite.java, which is just a service provider for Appwrite client?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I apologize for having a weak understanding here. I have removed all of the UI logic from Appwrite.java. However, I still think that having Appwrite.java is helpful as it will serve as the one place where all IDs and endpoints related to Appwrite are kept. LMK if you feel otherwise.

src/routes/docs/tutorials/android/step-4/+page.markdoc Outdated Show resolved Hide resolved
@gewenyu99
Copy link
Contributor

Hey,

Due to time constraints, I'm going to mark this PR hacktoberfest-accepted for now so you get DO's Hacktoberfest rewards. We'll continue to work with you on this issue for review and merge.

When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag.

Thanks for helping us improve Appwrite!

@gewenyu99 gewenyu99 added documentation Improvements or additions to documentation hacktoberfest-accepted labels Oct 31, 2023
@letsintegreat
Copy link
Author

letsintegreat commented Nov 4, 2023

@gewenyu99 Thanks a lot for such a thorough review, I really appreciate the time and effort you have put into reviewing my PR. I apologize for replying late, I caught up in some college work. However, I have now addressed all the requested changes and would like you to review this PR again. Thanks!

@gewenyu99
Copy link
Contributor

I'm gonna merge this into a branch and see what I can do to make this up to our docs' standards. Thank you!

@gewenyu99 gewenyu99 changed the base branch from main to feat-android-java-tutorial November 17, 2023 21:40
Copy link

vercel bot commented Nov 17, 2023

@gewenyu99 is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@gewenyu99 gewenyu99 merged commit 2284e9e into appwrite:feat-android-java-tutorial Nov 17, 2023
1 check failed
@gewenyu99
Copy link
Contributor

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@letsintegreat
Copy link
Author

@gewenyu99 my discord username is letsintegreat

@gewenyu99
Copy link
Contributor

Will reach out ASAP. Preparing lots of forms for everyone! Appreciate your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📚 Documentation: Android tutorial using Java
2 participants