-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial for android java #271
Add tutorial for android java #271
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi, can you give use the originals (unedited) of all your screenshots in light and dark more? Uncropped 16:9. For console screenshots 1400x900 We'll also have to redo your other images, but we'll accept this without visuals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I took my first look. Thank you so much for contributing to Appwrite, appreciate the effort you put in!
I have a few preliminary comments. Please take a look.
Love the idea, concerned about how complicated the auth components look :P
It will be used in **MainActivity** to check if the user is already logged in or not. | ||
|
||
```java | ||
public static void onGetAccount(Context context) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing imports. These should not be in Appwrite.js tbh. Why is there UI logic in Appwrite.java, which is just a service provider for Appwrite client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I apologize for having a weak understanding here. I have removed all of the UI logic from Appwrite.java
. However, I still think that having Appwrite.java
is helpful as it will serve as the one place where all IDs and endpoints related to Appwrite are kept. LMK if you feel otherwise.
Hey, Due to time constraints, I'm going to mark this PR When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag. Thanks for helping us improve Appwrite! |
@gewenyu99 Thanks a lot for such a thorough review, I really appreciate the time and effort you have put into reviewing my PR. I apologize for replying late, I caught up in some college work. However, I have now addressed all the requested changes and would like you to review this PR again. Thanks! |
I'm gonna merge this into a branch and see what I can do to make this up to our docs' standards. Thank you! |
@gewenyu99 is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
2284e9e
into
appwrite:feat-android-java-tutorial
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
@gewenyu99 my discord username is letsintegreat |
Will reach out ASAP. Preparing lots of forms for everyone! Appreciate your patience! |
What does this PR do?
Closes #82
This PR adds a tutorial to
/docs/tutorials/android
The tutorial gives a step-by-step guide to creating a recipe-sharing app - Recipewrite with Android and Java.
Test Plan
The final code can be found here, if you would like to test it.
Have you read the Contributing Guidelines on issues?
Yes.